Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed apikey references/usage from shopify plugin (#32024) #32033

Merged
merged 1 commit into from
Jun 22, 2021
Merged

removed apikey references/usage from shopify plugin (#32024) #32033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/gatsby-source-shopify/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ module.exports = {
{
resolve: "gatsby-source-shopify",
options: {
apiKey: process.env.SHOPIFY_ADMIN_API_KEY,
password: process.env.SHOPIFY_ADMIN_PASSWORD,
storeUrl: process.env.SHOPIFY_STORE_URL,
},
Expand Down Expand Up @@ -131,10 +130,6 @@ Now follow the second link to explore your Shopify data!

## Plugin options

`apiKey: string`

The admin API key for the Shopify store + app you're using

`password: string`

The admin password for the Shopify store + app you're using
Expand Down Expand Up @@ -250,7 +245,6 @@ module.exports = {
{
resolve: "gatsby-source-shopify",
options: {
apiKey: process.env.SHOPIFY_ADMIN_API_KEY,
password: process.env.SHOPIFY_ADMIN_PASSWORD,
storeUrl: process.env.SHOPIFY_STORE_URL,
downloadImages: true,
Expand Down
8 changes: 0 additions & 8 deletions packages/gatsby-source-shopify/__tests__/make-source-from-operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ describe(`The collections operation`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
downloadImages: true,
Expand Down Expand Up @@ -248,7 +247,6 @@ describe(`When polling an operation`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
downloadImages: true,
Expand Down Expand Up @@ -339,7 +337,6 @@ describe(`When downloading images`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
downloadImages: true,
Expand Down Expand Up @@ -446,7 +443,6 @@ describe(`A production build`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
}
Expand Down Expand Up @@ -513,7 +509,6 @@ describe(`A production build`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
}
Expand Down Expand Up @@ -604,7 +599,6 @@ describe(`When an operation gets canceled`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
}
Expand Down Expand Up @@ -677,7 +671,6 @@ describe(`When an operation fails with bad credentials`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
}
Expand Down Expand Up @@ -827,7 +820,6 @@ describe(`The incremental products processor`, () => {

const gatsbyApi = gatsbyApiMock as jest.Mock<SourceNodesArgs>
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
downloadImages: true,
Expand Down
2 changes: 0 additions & 2 deletions packages/gatsby-source-shopify/__tests__/node-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ describe(`When a variant has an image set`, () => {

describe(`and options are set, not to download images`, () => {
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
}
Expand All @@ -70,7 +69,6 @@ describe(`When a variant has an image set`, () => {

describe(`and options are set to download images`, () => {
const options = {
apiKey: ``,
password: ``,
storeUrl: `my-shop.shopify.com`,
downloadImages: true,
Expand Down
1 change: 0 additions & 1 deletion packages/gatsby-source-shopify/src/gatsby-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export function pluginOptionsSchema({
// Vague type error that we're not able to figure out related to isJoi missing
// Probably related to Joi being outdated
return Joi.object({
apiKey: Joi.string().required(),
password: Joi.string().required(),
storeUrl: Joi.string()
.pattern(/^[a-z0-9-]+\.myshopify\.com$/)
Expand Down
1 change: 0 additions & 1 deletion packages/gatsby-source-shopify/types/interface.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
interface ShopifyPluginOptions {
apiKey: string;
password: string;
storeUrl: string;
downloadImages?: boolean;
Expand Down