feat: shim reporter from gatsby #29669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Feb 22, 2021
| import { | ||
| extractFieldWithoutUnion, | ||
| extractAllCollectionSegments, | ||
| switchToPeriodDelimiters, | ||
| stripTrailingSlash, | ||
| } from "./path-utils" | ||
|
|
||
| type Reporter = typeof reporter |
There was a problem hiding this comment.
I'm unsure if there is a better way for this? Maybe also export { IReporter} from gatsby/reporter
cc @ascorbic
There was a problem hiding this comment.
Yes, adding a type export would be good. gatsby-cli/lib/reporter/reporter includes a type export for Reporter, so you could add export { Reporter } from "gatsby-cli/lib/reporter/reporter" inside reporter.d.ts
LekoArts
added
topic: reporter
and removed
status: triage needed
ascorbic
approved these changes
Feb 22, 2021
This was referenced Mar 12, 2021
Closed
build(deps): bump gatsby-transformer-remark from 3.0.0 to 3.1.0
MorrisonCole/morrisoncole.co.uk#1814
Merged
Merged
Closed
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Merged
Closed
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shimming the reporter in gatsby allows us to refactor it in the future without a breaking change. I was supprised so little packages were relying on the direct import of reporter.
Documentation
Related Issues
[ch23107]