Convert package-lock.json to yarn.lock #81
Conversation
When calling `gatsby new`, the command clones the repo and calls `yarn` on it. Yarn creates its own lockfile and throws a warning on every subsequent run because there are both a `yarn.lock` and a `package-lock.json`. This commit uses the `synp` npm package to fix that by converting `package-lock.json` to `yarn.lock` using these commands: ``` npm i npx synp --source-file ./package-lock.json yarn --update-checksums git rm -f ./package-lock.json git add yarn.lock ```
|
We add a package-lock.json because gatsby new defaults to using yarn if it's installed but then sometimes people will install packages with npm. If there's not a package-lock.json then npm will delete all packages other than what it's installing which causes lots of issues. There's a few ways we could fix this e.g. don't support yarn, ask people if they want to use yarn or npm when creating a site, etc. Ideally we wouldn't ship a lock file at all. |
|
So yeah, the fix right now for the warning is to just remove the package-lock.json. |
Ok didn't know that, thanks for the explanation. I should've seen 82b2681 and/or opened an issue before sending the PR. There is also an open issue about it here yarnpkg/yarn#5240.
Yeah I guess this situation will be easier once yarnpkg/yarn#5654 has some kind of resolution. |
When calling
gatsby new, the command clones the repo and callsyarnon it.Yarn creates its own lockfile and throws a warning on every subsequent run because there are both a
yarn.lockand apackage-lock.json.This commit uses the synp npm package to fix that by converting
package-lock.jsontoyarn.lockusing these commands: