Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change API delete mappings server/client end-points #251

Closed
allopez7 opened this issue Oct 9, 2019 · 2 comments
Closed

Change API delete mappings server/client end-points #251

allopez7 opened this issue Oct 9, 2019 · 2 comments
Assignees
@rkalra247
Labels
Launch Blocker

Comments

@allopez7
Copy link
Collaborator

allopez7 commented Oct 9, 2019

for example:
currently: mappings/delete/${data.id}
should be: mappings/${data.id}
@allopez7 allopez7 self-assigned this Oct 9, 2019
@allopez7 allopez7 changed the title Change mappings server end-points Change mappings server/client end-points Oct 9, 2019
@songz
Copy link
Collaborator

songz commented Dec 3, 2019

https://github.com/garageScript/myProxy/blob/master/src/api/mapping.ts#L97

@songz songz changed the title Change mappings server/client end-points Change API delete mappings server/client end-points Dec 6, 2019
@rkalra247 rkalra247 assigned rkalra247 and unassigned allopez7 Dec 6, 2019
@songz
Copy link
Collaborator

songz commented Dec 7, 2019

Fixed: #318

@songz songz closed this as completed Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkalra247 rkalra247

Labels
Launch Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@songz @rkalra247 @allopez7