-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue when running many productions in on the same machine in parallel #1211
base: main
Are you sure you want to change the base?
Conversation
Did run the tests twice with above command - all tests passed. |
Thanks! I will give the others a chance to run the tests as well before I merge. |
Failed on my laptop. I'm up to date with this branch and checked that all the unit tests passed. I ran the command above and got 65 failed, 15 passed in 28.45 s. All of them are AssertionError: Application failed. |
Also fails for me:
This is exactly the same error as before. |
This is not great because I cannot reproduce the errors...
I ran this 3 times and do not see an error. How do we find the difference between our setups? My branch is as follows:
The hash of the container I am using is Does this information help? |
This seems to be the same as for me:
Running with remote DB in a podman container which I start with (exactly as in the manual):
I assume you are running this in a container and you are giving docker/podman many cores? I have assigned podman 10 cores. |
My branch is the same:
I am not using docker, I am running it in a linux terminal with the simtools-dev conda environment using all 14 cores of my laptop. |
I run with podman container with 8 cores assigned. |
Yes, exactly the same.
Same, you can see I also tried downloading the latest container which was created |
Which podman version are you using? Podman v5.2.4? |
5.2.0 (which is weird since I just updated my client yesterday, but I guess it is different to the CLI). |
Pulled the latest image (gammasimtools-0.7.1.dev603+gd5737230f) and I am using podman 5.2.0 |
I even used the same random order seed as Gernot and I still don't get the errors. I also printed the version and get
|
Oh, my version seems to be different:
|
I think this is just because you do not run |
No one complained about tests failing with this branch, so I open this PR which should fix #1209.
I mark everyone to review, partly because it would actually be good for everyone to run tests locally and see if any of the integration tests fail and partly because it is short and the first one can do it.
Best way to run the tests is with the following command:
Closes #1209.