Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests for model_parameters; add read parameters from file #1081

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

GernotMaier
Copy link
Contributor

Add the following related to the model_parameters module:

  • allow to change model_parameters read from a file. This is clearly an experimental feature (for now) and a corresponding warning is printed out. I would keep it as it is for now, until we find time to either replace or improve it (this functionality has been there before, see the replace in validate_cumulative_psf.py
  • improve unit tests for model_parameters and get coverage to 100%.

@GernotMaier GernotMaier self-assigned this Jul 18, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

@GernotMaier GernotMaier marked this pull request as ready for review July 18, 2024 14:56
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (91.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

Copy link
Collaborator

@tobiaskleiner tobiaskleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks. Do we need to open an issue to remove this in the future or to add additional validation steps?

@GernotMaier
Copy link
Contributor Author

Thanks for the review!

I've added a issue #1084

@GernotMaier GernotMaier merged commit 66e847e into main Jul 19, 2024
16 checks passed
@GernotMaier GernotMaier deleted the change-model-parameters-from-file branch July 19, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants