Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept rational-precision mixed profiles for logit_estimate #458

Open
tturocy opened this issue Jun 12, 2024 · 1 comment
Open

Accept rational-precision mixed profiles for logit_estimate #458

tturocy opened this issue Jun 12, 2024 · 1 comment
Labels
cython Items which involve coding in Cython good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python

Comments

@tturocy
Copy link
Member

tturocy commented Jun 12, 2024

At the moment logit_estimate expects the strategy profile passed to be of float (double) precision. There's no conceptual reason these couldn't be of rational precision as well; indeed that may be most natural when working with count data.

Extend this method to allow rational precision profiles, by internally creating a copy of the profile in float precision and passing it on to the implementing function(s).
@tturocy tturocy added good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python cython Items which involve coding in Cython labels Jun 12, 2024
@Manan21st Manan21st mentioned this issue Aug 4, 2024
Open
@Manan21st
Copy link

I had raised a pr for this issue last week. Please look into it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cython Items which involve coding in Cython good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tturocy @Manan21st