Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Missing formats in Game.write #454

Closed
tturocy opened this issue Apr 11, 2024 · 3 comments
Closed

BUG: Missing formats in Game.write #454

tturocy opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
bug cython Items which involve coding in Cython
Milestone

Comments

@tturocy
Copy link
Member

tturocy commented Apr 11, 2024

The Game.write function documentation advertises that "efg" and "nfg" are valid options for the format; however, these are not implemented.

For "efg" this is maybe not that interesting, but for "nfg" it is somewhat relevant (if someone wanted to write out the strategic form of an extensive game, for some reason).

This applies to 16.1.x and 16.2.0.

@tturocy tturocy added bug cython Items which involve coding in Cython labels Apr 11, 2024
@tturocy tturocy added this to the gambit-16.3.0 milestone Apr 11, 2024
@tturocy tturocy self-assigned this Apr 11, 2024
@tturocy
Copy link
Member Author

tturocy commented Jul 16, 2024

Here's our proposed plan for this:

  • Fix this in maint16_1 for the next release of 16.1.
  • Merge that fix into maint16_2 and master.
  • In 16.3, we will deprecate this in favour of the new functions we are going to develop as part of ENH: Revise Python API for loading/saving games #357.
  • In 16.4, we will remove this function entirely.

@d-kad
Copy link
Contributor

d-kad commented Jul 18, 2024

Let me double-check I get the task right: 

  1. Do you mean we would completely get rid of the format “native” and replace it with “nfg”?
  2. How do you see the functionality implemented - do we add branching for “nfg” both in the python function write() and in WriteGame()?

@tturocy
Copy link
Member Author

tturocy commented Jul 19, 2024

We want to keep "native". It's that "efg" and "nfg" are claimed by the documentation to work, and they do not!

I believe this should just be a matter of handling the "efg" and "nfg" options in the WriteGame wrapper function in util.h, as the corresponding C++ Write function on games is supposed to handle this. But we need to check it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cython Items which involve coding in Cython
Projects
None yet
Development

No branches or pull requests

2 participants