Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: action values for zero-probability infosets should be undefined #446

Open
rahulsavani opened this issue Feb 11, 2024 · 1 comment
Open
Labels
c++ Items which involve writing in C++

Comments

@rahulsavani
Copy link
Member

rahulsavani commented Feb 11, 2024

Currently, the action value (stored in map_actionsValues) for actions at zero-probability information sets are zero. This enhancement would instead have these recorded as undefined. This may require changing the type of values of the map which is currently, via a template, either a double of Gambit.Rational, or just not populating it for the respective actions at zero-prob infosets.

@rahulsavani rahulsavani added the c++ Items which involve writing in C++ label Feb 11, 2024
@tturocy
Copy link
Member

tturocy commented Feb 11, 2024

We'll also need to give some consideration about the best way to do this, given that C++ does not have a natural "null" value. One possibility is to raise an exception, though this will take a bit of care to ensure code that calls this currently is ready for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Items which involve writing in C++
Projects
None yet
Development

No branches or pull requests

2 participants