Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: prevent decoding other CBOR types to cbor.SimpleValue #462

Closed
fxamacker opened this issue Jan 1, 2024 · 0 comments · Fixed by #464
Closed

bug: prevent decoding other CBOR types to cbor.SimpleValue #462

fxamacker opened this issue Jan 1, 2024 · 0 comments · Fixed by #464
Assignees
@fxamacker
Labels
bug Something isn't working
Milestone
v2.6.0

Comments

@fxamacker
Copy link
Owner

Currently, decoder can decode CBOR integers (not CBOR simple value) to cbor.SimpleValue. However, CBOR simple value (major type 7) is different from integers and shouldn't be used interchangeably.

Fix this by only allowing CBOR simple values (major type 7) to be decoded to cbor.SimpleValue.
@fxamacker fxamacker added the bug Something isn't working label Jan 1, 2024
@fxamacker fxamacker added this to the v2.6.0 milestone Jan 1, 2024
@fxamacker fxamacker self-assigned this Jan 1, 2024
@fxamacker fxamacker mentioned this issue Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

Fix cbor.SimpleValue encoding and decoding fxamacker/cbor
1 participant
@fxamacker