Set "typeofs: false" to prevent mangling typeofs by uglify

[lxe]

typeofs: true (default) transforms typeof foo == "undefined" into foo === void 0.

This mangles mapbox-gl creating an error when used alongside with window global mangling:

webpack-contrib/uglifyjs-webpack-plugin#189

[lxe]

cc @vicapow

[KevinGrandon]

Thanks for the PR. Would it be possible to add a unit test which illustrates where this would cause a problem? It would be great to ensure that we don't break this again in the future.

[KevinGrandon]

I would prefer to not mention project-specific bugs, and probably avoid links to websites not accessible to the public within the code.

[lxe]

This is generically reproducible... I want to get the static server to run though... see slack :)

[vicapow]

Do you have other compile configuration tests we can use as an example?

[KevinGrandon]

Do you have other compile configuration tests we can use as an example?

It depends on the behavior of what happens if there was an error. It sounds like this possibly exhibits as a node.js runtime error? If we can add a fixture with logic that reproduces this to the fixtures directory, we should be able to add a test like the following which ensures SSR works:

fusion-cli/test/cli/build.js

Lines 444 to 449 in 9e87239

	const {stdout} = await run(entry, {stdio: 'pipe'});
	const testContent = JSON.parse(stdout);
	t.ok(
	testContent.dynamicContent.includes('loaded dynamic import'),
	'dynamic import is executed'
	);

Alternatively, if you help us create a minimal repo which reproduces the issue, we can incorporate it as a fixture with test. Maybe on top of yarn create fusion-app for example.

[lxe]

Yes I can reproduce this generically. I'll add a "unit" test.

[mlmorg]

Please remove this

[mlmorg]

Supposedly this was fixed in the latest mapbox-gl: mapbox/mapbox-gl-js#6956. Can we simply stop using the old versions?

[vicapow]

Good catch @mlmorg i agree we should just update the dep if this is fixed upstream.

[lxe]

Supposedly this was fixed in the latest mapbox-gl: mapbox/mapbox-gl-js#6956. Can we simply stop using the old versions?

This is still an issue unrelated to mapbox specifically, (but manifests itself there). People will be using older versions of mapbox and fusion in the wild, and it should be able to be compatible with these sort of cases.

Besides, uglification changes like there won't affect the bundle size much

[KevinGrandon]

I think I am ok taking these changes in favor of correctness. I was unable to figure out what kind of code causes an error in Fusion, latest mapbox-gl seems to work fine. It's highly possible that this will break without a test in the future though.