Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cmake and package files #22

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

fujitatomoya
Copy link
Owner

address part of #19

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link
Owner Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rolling (jazzy will be aligned with this) is pass, but humble and iron. this is because yaml-cpp upgrades CMake things in v0.8.0.

--- stderr: parameter_server
CMake Error at CMakeLists.txt:36 (add_executable):
  Target "server" links to target "yaml-cpp::yaml-cpp" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Generate step failed.  Build files cannot be regenerated correctly.
---

there are 2 ways we could take,

  1. generating the distro branch for the source code. this will generate the burden for maintenance.
  2. Having some if statement to process differently either yaml-cpp version is greater than 0.8.0 or less.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/update-cmake-package-file branch from 49e7369 to 818c6e6 Compare April 30, 2024 18:07
@fujitatomoya
Copy link
Owner Author

Having some if statement to process differently either yaml-cpp version is greater than 0.8.0 or less.

818c6e6

@fujitatomoya
Copy link
Owner Author

okay, now all workflows are green, i will merge this into master.

@fujitatomoya fujitatomoya merged commit 0f0e64e into master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant