This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
emit NotificationFailed on critical failure #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftw-soft
suggested changes
Jul 17, 2019
| @@ -76,6 +77,12 @@ public function send($notifiable, Notification $notification): void | |||
| $message->toArray() | |||
| ); | |||
| } catch (BadResponseException $exception) { | |||
| event(new NotificationFailed($notifiable, $notification, $this, [ | |||
There was a problem hiding this comment.
You don't have to do like that. This is unattended behavior, also event is not obvious dependency, there is EventDispatcher class exists for that
You must catch this Exception on your business layer
There was a problem hiding this comment.
Could you point me the proper way to catch that? In my testing, once the Notification has been given over to Laravel there's no way to catch errors it throws
There was a problem hiding this comment.
Try to read manual and internal Laravel code more accurately.
Unfortunately, I can't help you with this now
|
There is no obvious reason to accept this pull request now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking inspiration from here and here this modifies the channel to emit the
NotificationFailedif there is a critial failure.I'm using this to back-peddle if I try to send a message via email to a user's email and get back:
I'm happy to add tests for this if you want, but the
IntercomChannelTesttest didn't seem to have access to the app, facades, or event mocks. Could use some guidanceThanks