LocalFileSystem.rm support for a sequence of string arguments #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
commented
Jun 18, 2021
| @@ -122,14 +122,18 @@ def mv_file(self, path1, path2, **kwargs): | |||
| shutil.move(path1, path2) | |||
|
|
|||
| def rm(self, path, recursive=False, maxdepth=None): | |||
There was a problem hiding this comment.
maxdepth is not used in this function...
d-v-b
changed the title
|
Ref: #651 about parameterised testing of many/all filesystems |
|
Thanks for turning this around quickly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalFileSystem.rm(path)now works ifpathis a sequence of strings. Resolves #677 but not the deeper issue -- the tests intest_mappingare not parametrized over different filesystems, and so there is no general mechanism way to catch this kind of API mismatch.