Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid isfile calls on find as much as possible #676

Merged
merged 2 commits into from
Jun 21, 2021

Commits on Jun 18, 2021

  1. avoid isfile calls on find as much as possible

    If `walk` is also returning the same file, it should already have
    been included in the `out`. If `out` is not empty, we can
    safely assume that it is either a directory or a file.
    
    If it's empty, it could be that it is either an empty directory
    or, the path is a file and was not included from the `walk` results.
    This time we will make a `isfile` call. This is unfortunate but
    better than before, where we were making an additional for each find.
    
    This was noticed in DVC, which was making remote cache querying slower
    when traversing through the caches (512 calls instead of 256 :( ).
    skshetry committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    66ee7d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. add tests

    skshetry committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    1e85844 View commit details
    Browse the repository at this point in the history