Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to cp/get/put directory with files with same name prefix #1340

Merged
merged 37 commits into from
Aug 31, 2023

Conversation

john-jam
Copy link
Contributor

@john-jam john-jam commented Aug 22, 2023

One test case in gcsfs has a weird behavior where copying a folder also copy files that have the same name prefix as the folder name. For example:

# Files
# -- subdir.txt
# -- subdir
# ---- subfile.txt

fs.cp("subdir", "target")

# Expected target folder content: ["subfile.txt"]

# Content with gcsfs: ["subdir.txt", "subdir/subfile.txt"]

This PR adds tests to cover this use case.
Also, a PR in gcsfs adds a fix for this issue.

TODO:

@martindurant martindurant merged commit 55e3042 into fsspec:master Aug 31, 2023
11 checks passed
@john-jam john-jam deleted the same-directory-file-names branch August 31, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants