Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FSharp.Control.IAsyncEnumerable in favor of the same type in BCL #159

Open
abelbraaksma opened this issue Nov 10, 2022 · 0 comments

Comments

@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 10, 2022

Description

With the event of TaskSeq coming to the masses, which used the NetStandard 2.1 IAsyncEnumerable, using both this lib and that one leads to issues because the same type with slightly different semantics lives in FSharp.Control.

This can be very subtle, for instance if your AsyncSeq reference is transient, you may not even be aware that you’ve brought this type into scope. Then you think you open the namespace of FSharp.Control to access taskSeq and code starts failing with confusing messages (confusing, because the different types look the same and have the same name).

I propose to deprecate that type in a next major version. This will also mean dropping support for NetStandard 2.0 and moving to 2.1, or to accept multiple versions of this library.

/cc @dsyme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant