Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSub fixes #6137

Merged
merged 1 commit into from
Nov 15, 2018
Merged

WebSub fixes #6137

merged 1 commit into from
Nov 15, 2018

Conversation

Alkarex
Copy link

@Alkarex Alkarex commented Nov 15, 2018

More fixes related to #6128

  • Bug when using direct ATOM URL, which ends with .atom after nick name
  • Bug when callback URL already has some ?query=parameters (which is quite usual)

Slight refactoring

More fixes related to friendica#6128
* Bug when using direct ATOM URL, which ends with .atom after nick name
* Bug when callback URL already has some ?query=parameters (which is
quite usual)
Slight refactoring
@Alkarex Alkarex mentioned this pull request Nov 15, 2018
@annando
Copy link
Collaborator

annando commented Nov 15, 2018

This part here is mainly used for the OStatus communication. So before even considering a merge, we have to double check if this will work in the future as well.

@Alkarex
Copy link
Author

Alkarex commented Nov 15, 2018

If I have not made any mistake, then the only case that might have worked before and that would not work anymore would be usernames ending in .atom (if this is a problem, this could be removed, especially if the other small problems in #6128 are fixed).
The rest is pure bug fixing and some refactoring that should not have any effect on what was already working.

@annando
Copy link
Collaborator

annando commented Nov 15, 2018

I just wanted to prevent a "rapid-finger-merge" ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants