Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS Return error "Total payments amount can't be greater than xx.x" #37998

Open
m4mousa opened this issue Nov 8, 2023 · 4 comments · May be fixed by #43253
Open

POS Return error "Total payments amount can't be greater than xx.x" #37998

m4mousa opened this issue Nov 8, 2023 · 4 comments · May be fixed by #43253
Labels

Comments

@m4mousa
Copy link

m4mousa commented Nov 8, 2023

Information about bug

  1. create POS Invoice with 2 items
  2. make a return for created POS Invoice
  3. return only one item
  4. Checkout
  5. message "Total payments amount can't be greater than xx.x" appears

Module

accounts, selling

Version

Frappe: 15
ERPNext: 15

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

@m4mousa m4mousa added the bug label Nov 8, 2023
@GursheenK GursheenK self-assigned this Jan 8, 2024
@KevinFaro
Copy link

KevinFaro commented Feb 28, 2024

I'm also experiancing this. It's also an issue if the payment for the original order is greater than the actual value of the order. Such as when paying cash and getting change. I think this is pretty serious.

@GursheenK The error is thrown here if this helps with your investigation.

We have a custom app, so have overridden this validator to no longer check this. We aren't seeing any issues yet, except for the default amount in the mode of payment matching the paid amount (full amount of cash given) instead of the actual value of the items being returned. This just means the cashier needs to set the payment amounts manually, which is okay, but not ideal as it leaves room for human error.

@Rebaz-balisani
Copy link

Rebaz-balisani commented Aug 13, 2024

I am using latest version and facing exactly same issue, if the invoice contains 1 item but with more than 1 quantity or more than 1 item in both cases you want to return only few items or quanitities so this error shows up, i hope they fix it because it seems this issue is there for long time @Nihantra-Patel

@GursheenK GursheenK removed their assignment Aug 20, 2024
@zahlenhexe
Copy link

I can confirm this.

My workflow is different.
This is how it worked in version-13:

  • scanning the returned item
  • click on the item and enter the negative quantity.
  • then go to payment to enter the pos invoice number the item is being returned to.

This is not longer possible in version-15.
When I want to make the payment with negativ quantity in cart, the message appears:
"Incorrect value: Grand Total (Company Currency) must be >= 0.0"
so it is not possible for me to accept returns at all.

I managed to solve this in my custom pos with editing pos_controller.js:

checkout: () => this.save_and_checkout(),

to

				//checkout: () => this.save_and_checkout(),
				checkout: () => this.payment.checkout(),

this is the old behavior.

I also described this in 2021 in the forum

@msalim79
Copy link

This is a issue I am also facing v14 and v15, please could the maintiners have a look into this , thanks

@Nihantra-Patel Nihantra-Patel linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants