Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignoredKeys in settings #232

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

francoismassart
Copy link
Owner

Better support for cva

Description

  • Add a new setting ignoredKeys
  • Add cva to the default list of callees
  • Add tests for this new ignoredKeys setting

Fixes #193

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tests added in no-custom-classname

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@its-monotype
Copy link

Works flawlessly even with tailwind-variants 👍 Can you please also add "tv" for tailwind-variants to the default list of callees?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CVA DefaultVariants read as class names
2 participants