Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OMG IDE support missing? #312

Closed
eyr1n opened this issue Jun 28, 2024 · 3 comments · Fixed by #313
Closed

OMG IDE support missing? #312

eyr1n opened this issue Jun 28, 2024 · 3 comments · Fixed by #313
Assignees
@achim-k
Labels
bug Something isn't working foxglove-bridge

Comments

@eyr1n
Copy link

eyr1n commented Jun 28, 2024

Description

Why is OMG IDE support missing since PR #293?

It seems to me that support is still needed for OMG IDL style interfaces because they can represent things that cannot be represented in ROS 2 IDL (e.g. sequence<T, N> type).

  • Version: 0.7.7
  • Platform: ROS 2 Humble w/ Ubuntu 22.04
@eyr1n eyr1n added the bug Something isn't working label Jun 28, 2024
@linear Linear
Copy link

linear bot commented Jun 28, 2024

FG-8082 OMG IDE support missing?

@achim-k
Copy link
Collaborator

achim-k commented Jun 28, 2024

This was not intended, will be fixed next week.

@achim-k achim-k self-assigned this Jun 28, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
@achim-k achim-k reopened this Jun 28, 2024
@achim-k achim-k mentioned this issue Jul 1, 2024
Merged
@achim-k
Copy link
Collaborator

achim-k commented Jul 1, 2024

@eyr1n could you give #313 a try and check if it fixes the issue?

achim-k added a commit that referenced this issue Jul 5, 2024
@achim-k
Fix parsing of IDL message definitions (#313)
b6c5022 
### Changelog
Fix parsing of IDL message definitions

### Docs
None

### Description
Fixes a regression introduced with #293 that caused that IDL message
definitions are not correctly handled anymore. This PR addresses this.

Fixes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achim-k achim-k

Labels
bug Something isn't working foxglove-bridge
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parsing of IDL message definitions foxglove/ros-foxglove-bridge
3 participants
@jtbandes @achim-k @eyr1n