Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 subscription smoke test testSubscription is flaky #248

Closed
achim-k opened this issue Jul 12, 2023 · 1 comment · Fixed by #260
Closed

ROS2 subscription smoke test testSubscription is flaky #248

achim-k opened this issue Jul 12, 2023 · 1 comment · Fixed by #260
Labels
linear

Comments

@achim-k
Copy link
Collaborator

achim-k commented Jul 12, 2023

Description
ROS2 CI jobs do not always succeed, if they fail, it's typically the testSubscription test.

See e.g. https://github.com/foxglove/ros-foxglove-bridge/actions/runs/5532236498/jobs/10094027554
@achim-k achim-k added the linear label Aug 15, 2023
@foxhubber
Copy link

foxhubber bot commented Aug 15, 2023

Internal tracking ticket: FG-4648

@jtbandes jtbandes changed the title ROS2 subsccription smoke test testSubscription is flaky ROS2 subscription smoke test testSubscription is flaky Aug 15, 2023
@achim-k achim-k mentioned this issue Aug 16, 2023
Merged
achim-k added a commit that referenced this issue Aug 16, 2023
@achim-k
make ROS 2 smoke tests less flaky (#260)
6f2e403 
### Public-Facing Changes

None

### Description
Attempt to make ROS 2 smoke tests less flaky

Fixes #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make ROS 2 smoke tests less flaky foxglove/ros-foxglove-bridge
1 participant
@achim-k