Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple M1 tracking issue #466

Closed
onbjerg opened this issue Jan 15, 2022 · 2 comments · Fixed by #468
Closed

Apple M1 tracking issue #466

onbjerg opened this issue Jan 15, 2022 · 2 comments · Fixed by #468

Comments

@onbjerg
Copy link
Member

onbjerg commented Jan 15, 2022

We can't compile for Apple M1 in CI currently because some packages break even when we try to cross-compile.

Will try to gather relevant issues here for tracking

@brockelmore
Copy link
Member

brockelmore commented Jan 15, 2022

I am not sure if we are able to, but adding this to cargo config has fixed issues in the past for M1 stuff. May be worth a shot trying

[target.x86_64-apple-darwin]
rustflags = [
  "-C", "link-arg=-undefined",
  "-C", "link-arg=dynamic_lookup",
]

[target.aarch64-apple-darwin]
rustflags = [
  "-C", "link-arg=-undefined",
  "-C", "link-arg=dynamic_lookup",
]

ref: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1

[edit]

Ehhhh i actually dont think this will fix the issue after diving deeper into the trail of issues

@brockelmore
Copy link
Member

better solution: remove the need of secp256k1 crate all together by refactoring this: https://github.com/bluealloy/revm/blob/main/crates/revm_precompiles/src/secp256k1.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants