Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update='append' does not work anymore #233

Closed
chenyuntc opened this issue Dec 26, 2017 · 1 comment
Closed

update='append' does not work anymore #233

chenyuntc opened this issue Dec 26, 2017 · 1 comment

Comments

@chenyuntc
Copy link

simple code to reproduce

import numpy as np
import visdom
vis = visdom.Visdom()
vis.line(np.arange(3),np.arange(3),win='test')
vis.line(np.arange(3),np.arange(3)+3,win='test',update='append')

It used to work, but I update visdom and it won't work any more.
I guess the problem comes from here

If I change it to :

        name = args.get('name')
        append = args.get('append')
        if name is None and append is None:
            return p  # we only updated the opts or layout

It works again. But I don't know whether it was the right way.

Since I use it a lot in my project and many other, I really hope it could be fix eariler.

Thanks for your great job to create such a lightweight and powerful visulization tool!

@chenyuntc chenyuntc changed the title update='append' not work anymore update='append' does not work anymore Dec 26, 2017
@JackUrb
Copy link
Contributor

JackUrb commented Dec 27, 2017

Ack sorry about this bug, going to push a fix right now. Pretty close to what you had, but I'm going to case it on the existence of new_data rather than append, which will fix appends and updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants