Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop when comparing regular expressions #399

Closed
mattmcdonald-uk opened this issue Feb 18, 2020 · 3 comments · Fixed by #400
Closed

Infinite loop when comparing regular expressions #399

mattmcdonald-uk opened this issue Feb 18, 2020 · 3 comments · Fixed by #400

Comments

@mattmcdonald-uk
Copy link
Contributor

When isSame is called with a regular expression, they are tested using a === b comparison.

As regular expressions are passed by reference these are never equal and causes an infinite loop within componentDidUpdate.
@mattmcdonald-uk mattmcdonald-uk mentioned this issue Feb 18, 2020
Merged
@rkuykendall
Copy link
Member

Re-opening until release.

@rkuykendall rkuykendall reopened this Feb 18, 2020
@rkuykendall
Copy link
Member

The fix is merged and will be released with 2.0.2.

@rkuykendall
Copy link
Member

This was fixed in version 2.0.2:

v2.0.2

v2.0.1...v2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test for regex equality
2 participants
@rkuykendall @mattmcdonald-uk