cloneIfObject converts arrays to objects

[twisty]

If you pass an array into this function, it returns an object.

formsy-react/src/utils.ts

Lines 47 to 50 in 6fcc682

	export function cloneIfObject(value: unknown) {
	// Clone objects to avoid accidental param reassignment
	return isObject(value) ? { ...value } : value;
	}

This is because this function returns true when passed an array:

formsy-react/src/utils.ts

Lines 7 to 9 in 6fcc682

	export function isObject(value: unknown): value is object {
	return value !== null && typeof value === 'object';
	}

(Try in browser console)

typeof []
> "object"

I'm not certain if arrays need to be cloned too, but a workaround is:

export function cloneIfObject(value: unknown) {
  // Clone objects to avoid accidental param reassignment
  if (isArray(value)) {
    return [...value];
  }
  return isObject(value) ? { ...value } : value;
}

...but then cloneIfObject isn't very well named!

[twisty]

Maybe cloneIfMutable would be a better name?

[rkuykendall]

@twisty Do you think this 'feature' of immutability is even worth keeping around considering this issue and #379 ?

[rkuykendall]

It seems like what we want for this check is less like isObject which returns true for arrays?!?! and more like isPlainObject which would also fix the moment bug. https://github.com/lodash/lodash/blob/aa1d7d870d9cf84842ee23ff485fd24abf0ed3d1/isPlainObject.js#L30

[twisty]

isPlainObject makes sense.

I would have no problem if the cloning was ditched. It would then just be up to the user to handle immutability themselves when they call setValue.

If we do keep the cloning, we should deal with the arrays properly, though!

[rkuykendall]

Released:

v2.0.1

• Respect dot notation in reset (Respect dot notation in reset #393) a2d2e5f
• Remove unnecesary externalError state (Remove unnecesary externalError state #398) d4eb73e
• Allow validation errors to be React elements (Allow validation errors to be React elements #394) 4096296
• Update rollup plugin libraries (Update rollup plugin libraries #397) bebefbe
• Improvements to README and PR Template (Improvements to README and PR Template #395) df5af84
• Fix types in Formsy spec tests (Fix types in Formsy spec tests #396) 954370a
• Remove unused Formsy props; tighten types; improve runRules (Remove unused Formsy props; tighten types; improve runRules #392) 0eaeef7
• Rename cloneIfObject to protectAgainstParamReassignment; Fix isObject (Rename cloneIfObject to protectAgainstParamReassignment; Fix isObject #391) 49fc634
• Added possibility to use browser builtin submit (Added possibility to use browser builtin submit #226) 761b3ef
• Improve test coverage (Improve test coverage #378) b8881d0
• Dependabot Automatic Library Bumps (Dependabot Automatic Library Bumps #376) 8b5a0db
• Use React's New Context API (Feature/new context api #198) a79eec2
• Fix in-page link to updateInputsWithValue 6fcc682
• Change coveralls from dependency to dev dependency c9d9db5
• Add coverage to gitignore 0afef60

v2.0.0...v2.0.1