Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release/0.3.0 #3

Merged
merged 3 commits into from
Feb 5, 2024
Merged

chore: release/0.3.0 #3

merged 3 commits into from
Feb 5, 2024

Conversation

justin-schroeder
Copy link
Member

A ran some manual tests on this. Everything went swimmingly — unquestionably an improvement (thanks @danielroe).

I’m documenting those manual tests so we can eventually get something them reproduced with automated testing in this repository:

  • Created a new formkit install using npx formkit@latest -f nuxt, specifically with pnpm
  • Before install I used a pnpm override to explicitly change the installed package to this branch’s build (perhaps there is a better way, but I’ve found the symlinks using link can cause module resolution issues when testing things like this).
  • Installed
  • Checked that the default app.vue rendered properly with no hydration issues or any FOUC
  • Replaced app.vue code with <NuxtPage /> and created 2 pages a.vue and b.vue with a.vue having a <FormKit> instance and b.vue having none.
  • Ran nuxi analyze to ensure we were getting the expect splits and a clean entry bundle.

Couple notes:

  1. Doing this highlighted that the @formkit/icons package is not tree shaking properly. This is now documented (@formkit/icons not properly tree shaking formkit#1184).
  2. The tailwindcss classes in formkit.config.ts should be an area of performance optimization. The only thing that needs to be there globally is the global classes. Other than that each input could be a seperate export in the generated file and directly imported. This might actually be a good candidate for unplugin-formkit, but I have not yet given it much further thought.

@justin-schroeder justin-schroeder merged commit b011811 into main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants