Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ran some manual tests on this. Everything went swimmingly — unquestionably an improvement (thanks @danielroe).
I’m documenting those manual tests so we can eventually get something them reproduced with automated testing in this repository:
npx formkit@latest -f nuxt
, specifically withpnpm
pnpm
override to explicitly change the installed package to this branch’s build (perhaps there is a better way, but I’ve found the symlinks usinglink
can cause module resolution issues when testing things like this).<NuxtPage />
and created 2 pagesa.vue
andb.vue
witha.vue
having a<FormKit>
instance andb.vue
having none.nuxi analyze
to ensure we were getting the expect splits and a clean entry bundle.Couple notes:
@formkit/icons
package is not tree shaking properly. This is now documented (@formkit/icons
not properly tree shaking formkit#1184).formkit.config.ts
should be an area of performance optimization. The only thing that needs to be there globally is the global classes. Other than that each input could be a seperate export in the generated file and directly imported. This might actually be a good candidate forunplugin-formkit
, but I have not yet given it much further thought.