-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComponentSet.fromSource() ignores component.isMarkedForDelete() in include filter #2826
Comments
Hello @jayree 👋 It looks like you didn't include the full Salesforce CLI version information in your issue. A few more things to check:
Thank you! |
Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support. |
This issue has been linked to a new work item: W-15771541 |
Hi, @mshanemc would it also be possible to mark all |
checking my understanding
|
@mshanemc yes, this is how I'm currently doing it: https://github.com/jayree/sfdx-plugin-manifest/blob/988f7bfa2ae0e02f3084a535b2031433b7ce8167/src/SDR-extra/collections/componentSetExtra.ts#L97 |
@jayree I've tried a few solutions to this, but they all ended up causing some integration test failures. |
Summary
ComponentSet.fromSource()
ignorescomponents
which aremarkedForDelete
ininclude
filter.Steps To Reproduce
componentSet
with components and mark them for deletion.componentSet
as aninclude
filter and create aComponentSet.fromSource()
Expected result
components
which aremarkedForDelete
are not listed inmanifestComponents
Actual result
components
which aremarkedForDelete
are listed inmanifestComponents
System Information
The text was updated successfully, but these errors were encountered: