Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link against libatomic if needed #95

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Link against libatomic if needed #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73207f2
Link against libatomic if needed
roehling Dec 10, 2020
08b9947
Add support for older compilers
roehling Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ else()
endif()

include(cmake/configuration.cmake)
include(cmake/atomic.cmake)

# subdirectories
add_subdirectory(src)
Expand Down
44 changes: 44 additions & 0 deletions cmake/atomic.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# check for atomic library, which is needed on some architectures
include(CheckCXXSourceCompiles)
function(check_cxx_atomic_compiles varname)
check_cxx_source_compiles("
#include <atomic>
std::atomic<bool> x;
int main() {
bool y = false;
return !x.compare_exchange_strong(y, true);
}" ${varname})
endfunction()
function(check_working_cxx_atomic varname)
check_cxx_atomic_compiles(${varname}_NOFLAG)
if(${varname}_NOFLAG)
set(${varname} TRUE PARENT_SCOPE)
return()
endif()
set(old_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
list(APPEND CMAKE_REQUIRED_FLAGS "-std=c++11")
check_cxx_atomic_compiles(${varname}_STD11)
set(CMAKE_REQUIRED_FLAGS "${old_CMAKE_REQUIRED_FLAGS}")
if(${varname}_STD11)
set(${varname} TRUE PARENT_SCOPE)
return()
endif()
list(APPEND CMAKE_REQUIRED_FLAGS "-std=c++0x")
check_cxx_atomic_compiles(${varname}_STD0X)
set(CMAKE_REQUIRED_FLAGS "${old_CMAKE_REQUIRED_FLAGS}")
if(${varname}_STD0X)
set(${varname} TRUE PARENT_SCOPE)
return()
endif()
set(${varname} FALSE PARENT_SCOPE)
endfunction()
check_working_cxx_atomic(HAVE_CXX_ATOMIC)
if(NOT HAVE_CXX_ATOMIC)
set(old_CMAKE_REQUIRED_LIBRARIES "${CMAKE_REQUIRED_LIBRARIES}")
list(APPEND CMAKE_REQUIRED_LIBRARIES "-latomic")
check_working_cxx_atomic(NEED_LIBRARY_FOR_CXX_ATOMIC)
set(CMAKE_REQUIRED_LIBRARIES "${old_CMAKE_REQUIRED_LIBRARIES}")
if(NOT NEED_LIBRARY_FOR_CXX_ATOMIC)
message(FATAL_ERROR "Host compiler does not support std::atomic")
endif()
endif()
4 changes: 4 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ set_target_properties(foonathan_memory PROPERTIES
OUTPUT_NAME "foonathan_memory-${FOONATHAN_MEMORY_VERSION}"
POSITION_INDEPENDENT_CODE ON)

if(NEED_LIBRARY_FOR_CXX_ATOMIC)
target_link_libraries(foonathan_memory PRIVATE -latomic)
endif()

install(TARGETS foonathan_memory EXPORT foonathan_memoryTargets
RUNTIME DESTINATION ${FOONATHAN_MEMORY_RUNTIME_INSTALL_DIR}
LIBRARY DESTINATION ${FOONATHAN_MEMORY_LIBRARY_INSTALL_DIR}
Expand Down