header file generation for QNX #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
part of ros2/ros2#988 |
foonathan
requested changes
Aug 4, 2020
foonathan
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
This fix allows generation of the header file container_node_sizes_impl.hpp on the native system when cross compiling for QNX since after comparison of the generated file on linux and QNX, I found that they are the same.
If host system is running Windows automatic header generation will not work. I have added in the CMakelist.txt file a check for the host system whether it is Linux or not. Also I added a message in case the developer is building on Windows that provides instructions on how to generate the file and where to put the file after generation so that it gets picked up and used during build.
I still need someone to generate the header file for me on a mac so that I can compare its output as well to see if it will match.