Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with BUILD_SHARED_LIBS=ON #132

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Fix build with BUILD_SHARED_LIBS=ON #132

merged 5 commits into from
Mar 30, 2022

Conversation

MiguelCompany
Copy link
Contributor

@MiguelCompany MiguelCompany commented Mar 29, 2022 •
edited
Loading

This should fix #131 by deprecating virtual_memory_page_size and adding function get_virtual_memory_page_size().

@MiguelCompany
CI with both options for BUILD_SHARED_LIBS
478e5d3 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Back to windows 2019
c101685 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany marked this pull request as draft March 29, 2022 13:21
@MiguelCompany MiguelCompany marked this pull request as ready for review March 29, 2022 14:56
@MiguelCompany MiguelCompany mentioned this pull request Mar 29, 2022
Closed
@foonathan
Copy link
Owner

Hm, this is a breaking change. Maybe it's better to call the function get_virtual_memory_page_size() and have a (deprecated) static const std::size_t virtual_memory_page_size = get_virtual_memory_page_size()? That being said, it probably doesn't matter. I leave the decision up to you.

@MiguelCompany
Using CMAKE_RUNTIME_OUTPUT_DIRECTORY
9e1141f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Add get_virtual_memory_page_size function.
cd88390 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Deprecate constant virtual_memory_page_size.
3e2f7d2 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Contributor Author

I do prefer non-breaking changes, so I just added the getter function that returns the constant.

@foonathan foonathan merged commit 5e523a9 into foonathan:main Mar 30, 2022
@foonathan
Copy link
Owner

Thank you!

@MiguelCompany MiguelCompany deleted the feature/dll-aware branch March 30, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building tests on Windows fails with BUILD_SHARED_LIBS=ON
2 participants
@MiguelCompany @foonathan