Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Include sync errors in ListControllers result #1010

Closed
squaremo opened this issue Mar 16, 2018 · 2 comments
Closed

Include sync errors in ListControllers result #1010

squaremo opened this issue Mar 16, 2018 · 2 comments

Comments

@squaremo
Copy link
Member

We now keep track of individual sync errors (failure to kubectl apply a resource). We could include this information in the output of ListControllers, so it can be shown by fluxctl list-controllers (for example).

@rndstr
Copy link
Contributor

rndstr commented Sep 19, 2018

We now keep track of individual sync errors

where?

@squaremo
Copy link
Member Author

We now keep track of individual sync errors

where?

"keep track" is possibly a little generous. I mean that we try to apply everything, and if that fails, we apply things individually -- so we see individual failures, if there are any. In https://github.com/weaveworks/flux/blob/master/cluster/kubernetes/sync.go#L116 and ff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants