Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing_app for upcoming release #658

Closed
domesticmouse opened this issue Jan 18, 2021 · 4 comments
Closed

Update testing_app for upcoming release #658

domesticmouse opened this issue Jan 18, 2021 · 4 comments
Assignees
@domesticmouse
Labels
enhancement New feature or request p1
Milestone
Backlog

Comments

@domesticmouse
Copy link
Contributor

From failed CI run:

== Testing 'testing_app' on Flutter's beta channel ==
~/work/samples/samples/testing_app ~/work/samples/samples
Running "flutter pub get" in testing_app...                      1,992ms
Analyzing testing_app...                                        

   info • 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. • lib/screens/favorites.dart:58:34 • deprecated_member_use
   info • 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. • lib/screens/home.dart:70:34 • deprecated_member_use
@domesticmouse domesticmouse self-assigned this Jan 18, 2021
@adarsh-technocrat
Copy link
Contributor

Hello @domesticmouse 👋 it would be great if you allow me to land PR for all the issues related to the Update that you have created recently.

@adarsh-technocrat adarsh-technocrat mentioned this issue Jan 21, 2021
Merged
@RedBrogdon RedBrogdon added enhancement New feature or request p1 labels Jan 31, 2021
@RedBrogdon RedBrogdon added this to the Backlog milestone Jan 31, 2021
@RedBrogdon
Copy link
Contributor

I've brought the beta branch up to date so this can be landed there.

@adarsh-technocrat
Copy link
Contributor

Hello @domesticmouse as related PR has been to merge to the beta branch we can close this issue :)

@domesticmouse
Copy link
Contributor Author

Woohoo 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domesticmouse domesticmouse

Labels
enhancement New feature or request p1
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@domesticmouse @RedBrogdon @adarsh-technocrat