Added the namespace property in build.gradle if the field is necessary. #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
AAverin
approved these changes
Dec 12, 2023
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
AAverin
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
AAverin
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
AAverin
requested changes
Feb 18, 2024
AAverin
reviewed
Feb 18, 2024
| @@ -38,6 +38,10 @@ apply plugin: 'com.android.library' | |||
| android { | |||
| compileSdkVersion 31 | |||
| ndkVersion "20.1.5948944" | |||
| // Condition for namespace compatibility in AGP 8 | |||
| if (project.android.hasProperty("namespace")) { | |||
There was a problem hiding this comment.
Probably android tools need to be bumped to the newer version 'com.android.tools.build:gradle:8.2.2'
At the moment CI fails
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR branch provide the package namespace if the AGP is equal or higher then 8.
Please Review: @AAverin