Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate fetchGit* #1343

Closed
rohaquinlop opened this issue Jun 26, 2024 · 0 comments
Closed

deprecate fetchGit* #1343

rohaquinlop opened this issue Jun 26, 2024 · 0 comments
Assignees
@rohaquinlop

Comments

@rohaquinlop
Copy link
Collaborator

rohaquinlop commented Jun 26, 2024 •
edited
Loading

Deprecate all the args fetchGit* type, they are too slow and have multiple issues. see discourse here and nixpkgs issue
@rohaquinlop rohaquinlop self-assigned this Jun 26, 2024
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 26, 2024
@rohaquinlop
feat(back): fluidattacks#1343 deprecate args git fetchers
b1ea481 
- Remove `fetchGithub` and `fetchGitlab` from
the agnostic.nix file.
- Replace `fetchGithub` and `fetchGitlab` with
`builtins.fetchTarball` in the `fetch-nix`,
`lint-git-mailmap` and
`secure-kubernetes-with-rbac-police` args.
- Update the fetchers documentation.
- The only `fetchGit` in the project is in the
`src/nix/sources.nix` file, which is generated by
Niv.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
dsalaza4 added a commit that referenced this issue Jun 26, 2024
@dsalaza4
Merge pull request #1344 from rohaquinlop/issue-1343
0fb94bc 
feat(back): #1343 deprecate args git fetchers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohaquinlop rohaquinlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohaquinlop