Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm: external modules bundled without their nested modules. #509

Open
UROjQ6r80p opened this issue Nov 29, 2023 · 3 comments
Open

pnpm: external modules bundled without their nested modules. #509

UROjQ6r80p opened this issue Nov 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@UROjQ6r80p
Copy link

External modules are bundled without their dependencies.

Example serverless.yml:

custom:
  esbuild:
    packager: pnpm
    external:
      - '@sparticuz/chromium'

module @sparticuz/chromium has dependencies:

  "dependencies": {
    "follow-redirects": "^1.15.3",
    "tar-fs": "^3.0.4"
  }

They are not included after command pnpm exec serverless package:
image

To Reproduce
Minimal repo to reproduce: https://github.com/UROjQ6r80p/serverless-esbuild-pnpm-no-nested-dependencies/tree/main

Expected behavior
Dependencies of modules to be bundled together.

Versions (please complete the following information):

  • OS: Windows 10
  • Serverless Framework Version: 3.38.0
  • Plugin Version: 1.49.0
@UROjQ6r80p UROjQ6r80p added the bug Something isn't working label Nov 29, 2023
@dvictory
Copy link

dvictory commented Dec 1, 2023

+1

@floydspace
Copy link
Owner

hey @dvictory thank you for raising it, currently, pnpm is not really reliable, so please keep an eye on this issue #506 it addresses that pnpm support must be adjusted

@mokone91
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants