Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html-theme): Add support for UTF-8 characters (for non-English documentation) #47

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

rxliuli
Copy link
Contributor

@rxliuli rxliuli commented Feb 6, 2021

I tried to use this library in a production environment, but it was garbled. After checking, I found that the <meta charset='UTF-8'> was not added to the page, so I fixed it as I went along

Before restoration

image

After restoration

image

@codeclimate
Copy link

codeclimate bot commented Feb 6, 2021

Code Climate has analyzed commit a800571 and detected 0 issues on this pull request.

View more on Code Climate.

@pklaschka pklaschka added the 🌷 enhancement New feature or request label Feb 6, 2021
@pklaschka pklaschka self-assigned this Feb 6, 2021
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much 🎉😃. I must confess that I didn't even think about non-English documentation. In hindsight, of course, it makes sense. Thanks again 👍 🙂

@pklaschka pklaschka changed the title Fix the problem of Chinese garbled fix(html-theme): Add support for UTF-8 characters (for non-English documentation) Feb 6, 2021
@pklaschka pklaschka merged commit d3159f6 into fliegwerk:main Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌷 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants