Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Search #10

Merged
merged 10 commits into from
Jan 11, 2021
Merged

feat: Search #10

merged 10 commits into from
Jan 11, 2021

Conversation

pklaschka
Copy link
Member

Adds search to the HTMLTheme

@pklaschka pklaschka added the 🌷 enhancement New feature or request label Jan 9, 2021
@pklaschka pklaschka added this to the 0.5.0 milestone Jan 9, 2021
@pklaschka pklaschka self-assigned this Jan 9, 2021
@pklaschka pklaschka marked this pull request as ready for review January 10, 2021 14:22
@pklaschka pklaschka enabled auto-merge (squash) January 10, 2021 14:22
fussel178
fussel178 requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little TS type suggestions and a typing error.
Everything else LGTM 😄

src/processors/type.ts Outdated Show resolved Hide resolved
src/processors/identifier.ts Outdated Show resolved Hide resolved
src/processors/init.ts Outdated Show resolved Hide resolved
src/processors/module.ts Outdated Show resolved Hide resolved
src/processors/module.ts Outdated Show resolved Hide resolved
src/processors/variable.ts Outdated Show resolved Hide resolved
pklaschka and others added 6 commits January 11, 2021 15:11
@pklaschka
Update src/processors/type.ts
b76554e 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Update src/processors/identifier.ts
95cd3b1 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Update src/processors/init.ts
34abd0f 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Update src/processors/module.ts
3ac9e38 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Update src/processors/module.ts
3dc19ec 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Update src/processors/variable.ts
cd53787 
Co-authored-by: Ludwig Richter <richter@fliegwerk.com>
@pklaschka
Copy link
Member Author

@fussel178 Thank you very much for your review. Yep, I changed it to default to unknown later in the process and forgot to update the references 👀 .

Kindly have a look again, it should now have been fixed, as per your suggestions 😉

@pklaschka pklaschka merged commit 0a3c342 into main Jan 11, 2021
@pklaschka pklaschka deleted the search-v2 branch January 11, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fussel178 fussel178 fussel178 approved these changes

Assignees

@pklaschka pklaschka

Labels
🌷 enhancement New feature or request
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@pklaschka @fussel178