Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REGRESSION] [Android, AndroidTV, Androidwear] When user has no default target defined in global renative.json, rnv launches target without asking user to choose #1375

Closed
pauliusguzas opened this issue Feb 5, 2024 · 0 comments
Closed

[REGRESSION] [Android, AndroidTV, Androidwear] When user has no default target defined in global renative.json, rnv launches target without asking user to choose #1375

pauliusguzas opened this issue Feb 5, 2024 · 0 comments
Assignees
@Marius456
Labels
bug Something isn't working
Milestone
1.0

Comments

@pauliusguzas
Copy link
Collaborator

Describe the bug
When user has no default target defined in global renative.json, rnv launches target without asking user to choose

To Reproduce

  1. Delete default target from global renative.json
  2. Have one simulator active
  3. Go to template-starter package (or harness)
  4. Do npx rnv run -p android -> app is installed and launched on open simulator

Expected behavior
rnv asks to choose from all targets

Desktop (please complete the following information):

  • OS: macOS Ventura 13.5.2
  • Node Version 18.19.0
  • RNV Version 1.0.0-rc.10
@pauliusguzas pauliusguzas added the bug Something isn't working label Feb 5, 2024
@pauliusguzas pauliusguzas changed the title [Android, AndroidTV, Androidwear] When user has no default target defined in global renative.json, rnv launches target without asking user to choose [REGRESSION] [Android, AndroidTV, Androidwear] When user has no default target defined in global renative.json, rnv launches target without asking user to choose Feb 5, 2024
@mihaiblaga89 mihaiblaga89 added this to the 1.0 milestone Feb 6, 2024
@Marius456 Marius456 self-assigned this Feb 9, 2024
@mihaiblaga89 mihaiblaga89 modified the milestones: 1.0, 1.1 Feb 12, 2024
@pavjacko pavjacko modified the milestones: 1.1, 1.0 Feb 13, 2024
@Marius456 Marius456 mentioned this issue Feb 17, 2024
Merged
@GabrieleKaceviciute GabrieleKaceviciute mentioned this issue Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marius456 Marius456

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@pavjacko @mihaiblaga89 @Marius456 @pauliusguzas