fix: prevent null exception when undefined/null Polygon.hitValue

[JaffaKetchup]

This works in the polyline layer, but I missed out a line copy when carrying some changes over.
Thanks to @mohammedX6 for bringing this to my attention. Replaces #1826.

[josxha]

lgtm

Sorry that I haven't seen this in my review.

edit: will do some additional testing, before I approve 😁

[josxha]

When you zoom in far like showcased in the video and then hover over the polygons the app crashes.

polygon.app.crashes.mp4

Not sure tho if this is related to this bug or another bug.

[JaffaKetchup]

Oooh, that's quite nasty, wonder if it's a memory leak or something, or whether the hover outlines are triggering it.

Outdated

[JaffaKetchup]

I can reproduce the increase in frame times, but not the crash (I assume that's device dependent). I'll try and do some more debugging.

[JaffaKetchup]

This is unrelated to tap detection, as it appears to be present prior to the introduction of this. It is present in commit f31829f.
I think this is safe to be reviewed & merged.

[mohammedX6]

maybe just setting the shouldRepaint to true is the safest option now ?

[JaffaKetchup]

Ah, the commit I mentioned above isn't necessarily the commit that caused it, just the previous one that I can reproduce the issue on.

[josxha]

Alright since it's not releated to this bug we can merge this pr. We should give the crash a high priority tho, maybe even create a bug report for it.

[JaffaKetchup]

Report made in #1829.