Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] (Re-)Support absolute Marker alignment #1771

Closed
JaffaKetchup opened this issue Dec 10, 2023 · 2 comments · Fixed by #1847
Closed

[FEATURE] (Re-)Support absolute Marker alignment #1771

JaffaKetchup opened this issue Dec 10, 2023 · 2 comments · Fixed by #1847
Assignees
@monsieurtanuki
Labels
feature This issue requests a new feature P: 2 (soon™?) S: core Scoped to the core flutter_map functionality
Milestone
v7.0

Comments

@JaffaKetchup
Copy link
Member

What do you want implemented?

Since v6, Markers can only be aligned relatively (on a scale of 0-1) through Alignment. It would be good for there to be an alternative constructor that takes a number of pixels from each edge, and the size of the Marker, and calculates the relative Alignment.

What other alternatives are available?

As an example, given the width (w) and number of pixels to offset from the left (d), the formula 1.0 - 2 * d / w can be used, as suggested by @Zverik in #1659 (comment).

Can you provide any other information?

No response

Severity

Annoying: Currently have to use workarounds
@JaffaKetchup JaffaKetchup added feature This issue requests a new feature P: 2 (soon™?) S: core Scoped to the core flutter_map functionality labels Dec 10, 2023
@JaffaKetchup JaffaKetchup mentioned this issue Dec 10, 2023
Merged
@monsieurtanuki
Copy link
Contributor

@JaffaKetchup @josxha May I work on this issue?

@JaffaKetchup
Copy link
Member Author

JaffaKetchup commented Mar 9, 2024 •
edited
Loading

Hey @monsieurtanuki,
Sure, we appricate any help we can get :) Huge thanks.

@monsieurtanuki monsieurtanuki mentioned this issue Mar 10, 2024
Merged
@JaffaKetchup JaffaKetchup linked a pull request Mar 10, 2024 that will close this issue
feat: add static Marker.computePixelAlignment method to calculate absolute alignment #1847
Merged
@JaffaKetchup JaffaKetchup changed the title [FEATURE] Add named constructor to Markers to allow absolute positioning [FEATURE] (Re-)Support absolute Marker alignment Mar 12, 2024
@josxha josxha added this to the v7.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
feature This issue requests a new feature P: 2 (soon™?) S: core Scoped to the core flutter_map functionality
Projects
Development
Archived in project
Milestone
v7.0
3 participants
@monsieurtanuki @josxha @JaffaKetchup