Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop kde own name #416

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Drop kde own name #416

wants to merge 2 commits into from

Conversation

bbhtt
Copy link

@bbhtt bbhtt commented Sep 28, 2023

No description provided.

This is no longer required with any supported runtimes, the issue was
fixed in Qt

https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier

> Most implementations of StatusNotifer have dropped this requirement

flathub-infra/flatpak-builder-lint#66 (comment)
@flathubbot
Copy link
Contributor

Started test build 69288

@flathubbot
Copy link
Contributor

Build 69288 failed

This is the only one that should be required
@flathubbot
Copy link
Contributor

Started test build 69289

@flathubbot
Copy link
Contributor

Build 69289 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51944/us.zoom.Zoom.flatpakref

@bbhtt
Copy link
Author

bbhtt commented Sep 28, 2023

I don't have a zoom account to test, please test this before merging. There's no way to trigger tray when logged out as far as I can see.

@takluyver
Copy link
Contributor

I've just tested this on Gnome (44.5 on Fedora 38). I didn't install this branch, but I removed the 'session bus owns' org.kde.* entry in Flatseal, which should be equivalent.

The status icon shows up, but the context menu breaks. With the 'owns' permission enabled, right or left clicking shows a Gnome-style menu nicely lined up with the icon:
Screenshot from 2023-10-11 15-32-17

Without this permission, left clicking activates the Zoom main window directly, and right clicking opens a non-styled menu in the top-left of my screen (not aligned with the status icon):

image

(The language difference is me messing with Zoom's own settings, not affected by this)

So I think it's best to leave this permission in place for the time being.

@bbhtt
Copy link
Author

bbhtt commented Oct 11, 2023

but I removed the 'session bus owns' org.kde.* entry in Flatseal, which should be equivalent.

I think --talk-name=org.kde.StatusNotifierWatcher will fix that, which this PR does too

@takluyver
Copy link
Contributor

My bad, I should have checked more carefully. However, when I make both changes in Flatseal, the status tray icon doesn't show up at all. 😕

@bbhtt
Copy link
Author

bbhtt commented Oct 11, 2023

Ok, I see the issue, it is using old Qt version and still using StatusNotifierItem PID-ID thing.

@bbhtt bbhtt marked this pull request as draft October 11, 2023 15:45
bbhtt added a commit to bbhtt/flatpak-builder-lint that referenced this pull request Jan 17, 2024
requires --own-name='org.kde.*' under flatpak

Only handles maintained applications that had activity in the past year

Zoom: flathub/us.zoom.Zoom#416
Discord: flathub/com.discordapp.Discord#324
DiscordCanary: flathub/com.discordapp.DiscordCanary#78
Celeste: flathub/com.hunterwittenborn.Celeste#35
Tribler: flathub/org.tribler.Tribler#10
Dropbox: flathub/com.dropbox.Client#318
barthalion pushed a commit to flathub-infra/flatpak-builder-lint that referenced this pull request Jan 23, 2024
requires --own-name='org.kde.*' under flatpak

Only handles maintained applications that had activity in the past year

Zoom: flathub/us.zoom.Zoom#416
Discord: flathub/com.discordapp.Discord#324
DiscordCanary: flathub/com.discordapp.DiscordCanary#78
Celeste: flathub/com.hunterwittenborn.Celeste#35
Tribler: flathub/org.tribler.Tribler#10
Dropbox: flathub/com.dropbox.Client#318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants