Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kde own name #17

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Drop kde own name #17

merged 2 commits into from
Sep 28, 2023

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Sep 28, 2023

No description provided.

@bbhtt
Drop org.kde.* own-name
24f1a39 
This is no longer required with any supported runtimes, the issue was fixed in Qt

https://docs.flatpak.org/en/latest/desktop-integration.html#statusnotifier

> Most implementations of StatusNotifer have dropped this requirement

flathub-infra/flatpak-builder-lint#66
@bbhtt
StatusNotifierWatcher should be the only permission required to provide
a5dc092 
tray functionalities on KDE
@flathubbot
Copy link
Contributor

Started test build 69374

@flathubbot
Copy link
Contributor

Build 69374 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52028/dev.deedles.Trayscale.flatpakref

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 28, 2023

Tested in a KDE Neon VM, seems to work

KDE

image

@DeedleFake
Copy link
Collaborator

This results in the following error in the logs that doesn't appear otherwise:

2023/09/28 11:19:06 systray error: failed to request name: org.freedesktop.DBus.Error.ServiceUnknown

The tray icon appears to work anyways, however.

According to the Flatpak documentation, older implementations of StatusNotifier require the ownership because they need to create an org.kde.StatusNotifierItem-$PID-1. This fails with this change, but it does seem like it is unnecessary on most systems now.

I'll merge this, but it is possible that this will break the icon on some systems.

@DeedleFake DeedleFake merged commit 3bf36ad into flathub:master Sep 28, 2023
2 checks passed
@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 28, 2023

According to the Flatpak documentation, older implementations of StatusNotifier require the ownership because they need to create an org.kde.StatusNotifierItem-$PID-1.

See the reference in the commit message, the PID-ID thing was fixed in Qt and fix is available in all supported runtimes. It should not cause any issue.

@bbhtt bbhtt deleted the drop-kde-own-name branch September 28, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbhtt @flathubbot @DeedleFake