Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: create image from URL #350

Merged
merged 7 commits into from
Aug 9, 2022
Merged

openstack: create image from URL #350

merged 7 commits into from
Aug 9, 2022

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Aug 9, 2022 •
edited
Loading

In this PR, we add the ability to ore openstack to create an image from an URL - this is quite handy for CI context, we could just provide the bincache URL to create the Openstack image of the tested version.

$ IMAGE_ID=$(./bin/ore openstack create-imag --file https://alpha.release.flatcar-linux.net/amd64-usr/3305.0.0/flatcar_production_openstack_image.img.gz ...)
$ ./bin/kola run ... --platform openstack --openstack-image "${IMAGE_ID}" kubeadm.v1.23.4.flannel.base

Vendor has been upgraded to the most recent version (0.25.0)

Related to: flatcar/Flatcar#785

@tormath1
vendor: go mod vendor
a6c31a8 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
mod: upgrade gophercloud
b904c5a 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
sum: go mod tidy
7704cbf 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
api/openstack: upgrade codebase following vendor upgrade
b7b0a47 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
os/api: support web-download for importing image
90bbda9 
image can be imported from a local path or from an URL.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
ore/openstack: add URL mention to file flag
5e12e5b 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
changelog: add entry
5140597 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 marked this pull request as ready for review August 9, 2022 08:10
@tormath1 tormath1 self-assigned this Aug 9, 2022
@tormath1 tormath1 requested a review from a team August 9, 2022 08:15
pothos
pothos approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I didn't test it. One related task is to teach ore gc to also delete left-over images and not only left-over servers.

@tormath1
Copy link
Contributor Author

tormath1 commented Aug 9, 2022

Looks good but I didn't test it. One related task is to teach ore gc to also delete left-over images and not only left-over servers.

@pothos thanks for the review. I was thinking to add SSH keys deletion too.

@tormath1 tormath1 mentioned this pull request Aug 9, 2022
Closed
@tormath1 tormath1 merged commit c8ed6c0 into flatcar-master Aug 9, 2022
@tormath1 tormath1 deleted the tormath1/openstack branch August 9, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pothos pothos pothos approved these changes

Assignees

@tormath1 tormath1

Labels
None yet
Projects
Flatcar tactical, release planning, and roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tormath1 @pothos