add some ignition/v3 test #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Mar 3, 2022
pothos
reviewed
Mar 3, 2022
tormath1
force-pushed
the
tormath1/ignition3
branch
from
e76bad9
to
a376805
Compare
tormath1
force-pushed
the
tormath1/ignition3
branch
from
ffa3306
to
d1933f2
Compare
pothos
reviewed
Mar 7, 2022
pothos
reviewed
Mar 7, 2022
tormath1
force-pushed
the
tormath1/ignition3
branch
from
da35281
to
8df4c83
Compare
this test is backport from coreos-assembler to test systemd instantiated services enabled via ignition. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
this helper runs cmd via SSH and panics if stdout does not contain expected Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
this test creates a symlink via ignition and assert it's correct. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
mainly to support config > 3.0.0 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/ignition3
branch
from
8df4c83
to
6d831e3
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com> Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/ignition3
branch
from
1aa5de2
to
69b6d94
Compare
pothos
approved these changes
Mar 21, 2022
jepio
reviewed
Mar 25, 2022
| } | ||
| }`), | ||
| Distros: []string{"cl"}, | ||
| }) |
There was a problem hiding this comment.
@tormath1 this need a MinVersion doesn't it?
There was a problem hiding this comment.
Oh yes, version 3.0.0... Totally missed this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add some Ignition V3 tests from
coreos/coreos-assemblerproject in order to be closer from the upstream. It also brings new test for IgnitionV3 on top ofUserDataV3ones.Tested with: http://localhost:9091/job/os/job/manifest/5049/cldsv/
NOTE:
kargstest could be upstreamedchangelog/directory (user-facing change, bug fix, security fix, update)