-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: extend CNI tests #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR must have slipped through the cracks, sorry about that. Looks good, but needs a rebase now.
cilium has fixed the IPSec probing issue with this release. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
kubernetes tests should be agnostic from the CNI, but some specific CNI features need to be tested. with this commit, we introduce a mechanism to extend the kubeadm test suite by adding `extraTests`. An `extraTest` is bound to the CNI, this aims to be used to extend CNI coverage. `extraTest` are ran from the `controller` node. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
we add a test case to cover cilium IPSec installation. Previous cilium deployment is deleted and a new one is done with `--encryption=ipsec` param. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/ipsec
branch
from
August 23, 2022 15:57
bd79f94
to
b9b5f71
Compare
Rebased and tested on Openstack:
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to extend kubeadm coverage by adding extra tests to test specific points for a CNI.
One test case has been added to cover the following use-case: flatcar/Flatcar#626 with IPSec encryption.
Note for reviewers:
Testing done
kubeadm.v1.23.0.cilium.base
changelog/
directory (user-facing change, bug fix, security fix, update)