Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: extend CNI tests #292

Merged
merged 4 commits into from
Aug 24, 2022
Merged

kubeadm: extend CNI tests #292

merged 4 commits into from
Aug 24, 2022

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Feb 15, 2022

This PR is an attempt to extend kubeadm coverage by adding extra tests to test specific points for a CNI.

One test case has been added to cover the following use-case: flatcar/Flatcar#626 with IPSec encryption.

Note for reviewers:

  • the cluster is kept to avoid increasing overall time execution

Testing done

  • kubeadm.v1.23.0.cilium.base
  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR must have slipped through the cracks, sorry about that. Looks good, but needs a rebase now.

cilium has fixed the IPSec probing issue with this release.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
kubernetes tests should be agnostic from the CNI, but some specific CNI
features need to be tested.

with this commit, we introduce a mechanism to extend the kubeadm
test suite by adding `extraTests`.
An `extraTest` is bound to the CNI, this aims to be used to extend CNI
coverage.

`extraTest` are ran from the `controller` node.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
we add a test case to cover cilium IPSec installation. Previous cilium
deployment is deleted and a new one is done with `--encryption=ipsec`
param.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
Copy link
Contributor Author

Rebased and tested on Openstack:

=== RUN   kubeadm.v1.24.1.cilium.base
=== RUN   kubeadm.v1.24.1.cilium.base/node_readiness
=== RUN   kubeadm.v1.24.1.cilium.base/nginx_deployment
=== RUN   kubeadm.v1.24.1.cilium.base/IPSec_encryption
--- PASS: kubeadm.v1.24.1.cilium.base (256.65s)
--- PASS: kubeadm.v1.24.1.cilium.base/node_readiness (35.24s)
--- PASS: kubeadm.v1.24.1.cilium.base/nginx_deployment (51.84s) 
--- PASS: kubeadm.v1.24.1.cilium.base/IPSec_encryption (3.88s)

Thanks for the review!

@tormath1 tormath1 merged commit 983bc79 into flatcar-master Aug 24, 2022
@tormath1 tormath1 deleted the tormath1/ipsec branch August 24, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants