cmd/cork,sdk: remove --repo-branch option from cork #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that repo 2.8 is available in all Flatcar channels, the option `--repo-branch` is not needed any more. Delete the option, and simply use the `master` branch of the git repo. This reverts commit 0713901.
2 tasks
tormath1
reviewed
Jan 28, 2022
dongsupark
force-pushed
the
dongsu/cork-repo-branch-revert
branch
from
a5cc020
to
add02cc
Compare
Yes, repo 2.8 is already in SDK of LTS 2605.24.1. |
krnowak
approved these changes
Jan 28, 2022
No, I don't think we need to change anything in jenkins-os. |
dongsupark
force-pushed
the
dongsu/cork-repo-branch-revert
branch
from
add02cc
to
ec1300b
Compare
tormath1
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that repo 2.8 is available in all Flatcar channels, the option
--repo-branchis not needed any more.Delete the option, and simply use the
masterbranch of the git repo.This reverts commit 0713901.
Testing done
local build passed
changelog/directory (user-facing change, bug fix, security fix, update)