kola: add Metro attribute to Equinix-Metal device creation
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
By adding this option, we delegate the choice of facility to EquinixMetal in function of the availability and other parameters in the facilities within the metro. See also: https://metal.equinix.com/developers/docs/locations/metros/ Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
instead of relying on the `facility` option, we are now using the one given by the device itself since with the Metro feature, we can't know by advance the facility of the device. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
changed the title
Metro attribute to Equinix-Metal device creatioMetro attribute to Equinix-Metal device creation
tormath1
force-pushed
the
tormath1/em-metro
branch
from
a2575de
to
9a9e372
Compare
jepio
approved these changes
Jan 26, 2022
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
1 task
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 26, 2022
Follow up of: flatcar/mantle#281 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we upgrade
packgnolibrary and add theMetroattribute to the device creation - this should decrease the pressure on the cloud provider since it will dispatch the load all along the facilities availability.See also: https://metal.equinix.com/developers/docs/locations/metros/
Testing done
Tested using
--equinixmetal-facilityand--equinixmetal-metroboth at the same time and tested with--equinixmetal-metro DAonly.changelog/directory (user-facing change, bug fix, security fix, update)