Azure gallery image support #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
reviewed
Jan 6, 2022
jepio
force-pushed
the
jepio/azure-gallery-support
branch
from
d68c63b
to
382639f
Compare
tormath1
approved these changes
Jan 7, 2022
GalleryImages can be created from a blob url, and can be republished on Azure marketplace in a simpler way than a vhd blob. This uses an ARM template as the azure-sdk-for-go currently does not support all parameters that we need to use. The gallery support is not enabled by default as there may be differences in semantics that we want to figure out before it becomes the default path. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
To unify with what we already do for GCP and AWS. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/azure-gallery-support
branch
from
382639f
to
1543a5c
Compare
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure gallery image support
This PR adds support for using gallery images on Azure. For now this is in kola only, to be used for testing. In a later step we could then move our publishing process to gallery images, which will reduce the possibility of errors when publishing on the marketplace. This would not simplify automation because the marketplace APIs only support VHD urls.
How to use
Testing done
Ran
kola spawnsuccessfully.changelog/directory (user-facing change, bug fix, security fix, update)