equinix-metal: recycle existing instances #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
changed the title
pothos
reviewed
Dec 14, 2021
pothos
reviewed
Dec 14, 2021
pothos
reviewed
Dec 14, 2021
pothos
reviewed
Dec 14, 2021
tormath1
force-pushed
the
tormath1/em
branch
from
ecf580f
to
2315216
Compare
pothos
reviewed
Dec 15, 2021
pothos
reviewed
Dec 15, 2021
pothos
reviewed
Dec 15, 2021
tormath1
changed the title
tormath1
changed the title
pothos
reviewed
Dec 16, 2021
pothos
reviewed
Dec 16, 2021
pothos
reviewed
Dec 16, 2021
pothos
reviewed
Dec 16, 2021
pothos
reviewed
Dec 16, 2021
pothos
reviewed
Dec 16, 2021
tormath1
force-pushed
the
tormath1/em
branch
from
7f0bcbc
to
34decbb
Compare
pothos
reviewed
Dec 17, 2021
pothos
reviewed
Dec 17, 2021
pothos
reviewed
Dec 17, 2021
pothos
approved these changes
Dec 17, 2021
|
I just started a final test: we should have max 6 devices created (the kubeadm tests create 3 machines each, the others just one each). Result: We got a maximum of 5 instances created and 3 instances have been recycled. |
we keep a trace of opened SSH client in order to close them properly later. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
we can now open, keep a trace and delete properly a SSH client. When the instance is created, its SSH client will be stored and closed when the device is marked as available. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This devicesPool will be used to keep the devices _after_ being used in order to create a pool of available device to be picked-up later instead of creating a new device. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
before creating a device we check if there are some available devices into a created pool of device. if one device is available this one will be updated in place in order to boot with a new PXE configuration to load fresh configuration without destroying the server. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
since the mach.Destroy only adds devices to the pool, we don't need to rely on it to actually remove a device. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
we now define CreateOrUpdateDevice. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/em
branch
from
34decbb
to
4fb3794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add the ability to mantle test to reuse existing Equinix Metal instances and to keep them into a pool of devices in the Flight lifecycle.
Closes: flatcar/Flatcar#551
changelog/directory (user-facing change, bug fix, security fix, update)